Add tests for stripping port in host header
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| test('strip port in host header if explicit standard port (:80) & protocol (HTTP)', async t => { | ||
| const {body} = await got('http://httpbin.org:80/headers', {json: true}); |
There was a problem hiding this comment.
I don't think we should use remote server when we can just use our local server. Using a remote endpoint slows down the tests and makes them more fragile.
There was a problem hiding this comment.
Listening on 80 or 443 is likely to crash (EACCESS)
There was a problem hiding this comment.
Right... We could have used nock, but I guess this is good enough then.
There was a problem hiding this comment.
Wait, I forgot about nock. I'll just push a commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588