Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs for proxy-pass #2326

Closed
wants to merge 1 commit into from
Closed

Conversation

jarqvi
Copy link

@jarqvi jarqvi commented Jan 29, 2024

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@jarqvi
Copy link
Author

jarqvi commented Jan 29, 2024

Hello!
I recently found myself in need of a specific code but couldn't locate a comprehensive solution. Following an examination of the documentation and conducting several tests, I reached the following conclusion.

As a result, I decided it would be beneficial to submit a pull request (PR) for this, along with an illustrative example, to assist others in utilizing it.

@sindresorhus
Copy link
Owner

I appreciate the pull request, but I feel like documenting Express usage is a bit outside of what we should document in Got. I suggest writing a blog post about it on your blog instead 👍

@jarqvi jarqvi deleted the proxy-pass-doc branch January 30, 2024 03:49
@jarqvi
Copy link
Author

jarqvi commented Jan 30, 2024

Hi @sindresorhus
Thanks.
What do you think if I provide an example in a PR using my HTTP built-in module? Honestly, I don't have a blog, but I really wanted to share this and thought it might be helpful with documentation updates. 🙂

@sindresorhus
Copy link
Owner

I'm still going to pass. More docs means more for us to maintain too. Non-essential docs are better done in community blogs.

You could for example share it here: https://dev.to

@jarqvi
Copy link
Author

jarqvi commented Jan 30, 2024

ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants