Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TypeScript 4.9 compatibility #2163

Merged
merged 1 commit into from Oct 12, 2022
Merged

Improve TypeScript 4.9 compatibility #2163

merged 1 commit into from Oct 12, 2022

Commits on Oct 11, 2022

  1. Update timed-out.ts 

    TypeScript 4.9 can narrow more correctly with the `in` operator. Since this property is declared as being always present, code that only runs if it's *not* present marks that variable as `never` and causes errors. The correct definition is to mark this as optional (alternatively, you can upcast `reentry` to `symbol` in the `in` checks, but that's more invasive and less correct)
    @RyanCavanaugh
    RyanCavanaugh committed Oct 11, 2022
    Copy the full SHA
    45dd4d2 View commit details
    Browse the repository at this point in the history