Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #1543: Initialize globalResponse in case of ignored HTTPError #2017

Merged
merged 2 commits into from Apr 6, 2022
Merged

Backport #1543: Initialize globalResponse in case of ignored HTTPError #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99100b6
Backport #1543: Initialize globalResponse in case of ignored HTTPError
nextlevelbeard Mar 25, 2022
d43781d
Add test for disabled throwHttpErrors
nextlevelbeard Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/as-promise/index.ts
View file
Open in desktop
Expand Up @@ -124,13 +124,13 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
return;
}

globalResponse = response;

if (!isResponseOk(response)) {
request._beforeError(new HTTPError(response));
return;
}

globalResponse = response;

resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
});

Expand Down
10 changes: 10 additions & 0 deletions test/promise.ts
View file
Open in desktop
Expand Up @@ -85,3 +85,13 @@ test('promise.json() can be called before a file stream body is open', withServe

await Promise.all(checks);
});

test('promise.json() does not fail when server returns an error and throwHttpErrors is disabled', withServer, async (t, server, got) => {
server.get('/', (_request, response) => {
response.statusCode = 400;
response.end('{}');
});

const promise = got('', {throwHttpErrors: false});
await t.notThrowsAsync(promise.json());
});