Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize globalResponse in case of ignored HTTPError #1543

Merged
merged 1 commit into from Nov 30, 2020
Merged

Initialize globalResponse in case of ignored HTTPError #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/as-promise/index.ts
View file
Open in desktop
Expand Up @@ -124,13 +124,13 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
return;
}

globalResponse = response;

if (!isResponseOk(response)) {
request._beforeError(new HTTPError(response));
return;
}

globalResponse = response;

resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
});

Expand Down
2 changes: 1 addition & 1 deletion test/promise.ts
View file
Open in desktop
Expand Up @@ -80,7 +80,7 @@ test('promise.json() can be called before a file stream body is open', withServe
await Promise.all(checks);
});

test.failing('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
test('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
server.get('/', (_request, response) => {
response.statusCode = 400;
response.end('{}');
Expand Down