Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate CacheableLookup only when needed #1529

Merged
merged 3 commits into from Nov 19, 2020
Merged

Instantiate CacheableLookup only when needed #1529

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5fb0cf
Instantiate CacheableLookup only when needed
fungiboletus Nov 19, 2020
e7e2077
Explicit type of the globalDnsCache variable.
fungiboletus Nov 19, 2020
b4440ed
Fix code style
fungiboletus Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/core/index.ts
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ import normalizePromiseArguments from '../as-promise/normalize-arguments';
import {PromiseOnly} from '../as-promise/types';
import calculateRetryDelay from './calculate-retry-delay';

const globalDnsCache = new CacheableLookup();
let globalDnsCache: CacheableLookup;

type HttpRequestFunction = typeof httpRequest;
type Error = NodeJS.ErrnoException;
Expand Down Expand Up @@ -1758,6 +1758,10 @@ export default class Request extends Duplex implements RequestEvents<Request> {

// `options.dnsCache`
if (options.dnsCache === true) {
if (!globalDnsCache) {
globalDnsCache = new CacheableLookup();
}

options.dnsCache = globalDnsCache;
} else if (!is.undefined(options.dnsCache) && !options.dnsCache.lookup) {
throw new TypeError(`Parameter \`dnsCache\` must be a CacheableLookup instance or a boolean, got ${is(options.dnsCache)}`);
Expand Down