Fix promise shortcuts in case of error status code (#1543)

sindresorhus · Nov 30, 2020 · ff918fb · ff918fb
1 parent 1107cc6
commit ff918fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/as-promise/index.ts b/source/as-promise/index.ts
@@ -124,13 +124,13 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
 					return;
 				}
 
+				globalResponse = response;
+
 				if (!isResponseOk(response)) {
 					request._beforeError(new HTTPError(response));
 					return;
 				}
 
-				globalResponse = response;
-
 				resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
 			});
 

diff --git a/test/promise.ts b/test/promise.ts
@@ -80,7 +80,7 @@ test('promise.json() can be called before a file stream body is open', withServe
 	await Promise.all(checks);
 });
 
-test.failing('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
+test('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
 	server.get('/', (_request, response) => {
 		response.statusCode = 400;
 		response.end('{}');