Drop support for checking object with path property in function returns by isGitIgnored
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found other bugs... |
fisker
commented
Jan 17, 2022
| @@ -34,7 +34,7 @@ const checkCwdOption = options => { | |||
| } | |||
| }; | |||
|
|
|||
| const getPathString = p => p.stats instanceof fs.Stats ? p.path : p; | |||
| const getPathString = fastGlobResult => fastGlobResult.path || fastGlobResult; | |||
There was a problem hiding this comment.
This function mean to handle fastGlobResult, but p.stats is not always true, see objectMode option in fast-glob
fisker
commented
Jan 17, 2022
| @@ -152,7 +152,7 @@ export const globby = async (patterns, options = {}) => { | |||
| const [filter, tasks] = await Promise.all([getFilter(options), getTasks()]); | |||
| const paths = await Promise.all(tasks.map(task => fastGlob(task.pattern, task.options))); | |||
|
|
|||
| return arrayUnion(...paths).filter(path_ => !filter(getPathString(path_))); | |||
There was a problem hiding this comment.
filter already handles objectMode result, not needed here, globbySync and globbyStream also not doing this.
|
This one is ready, but I saw another bug here, the |
|
Thanks for catching these bugs. I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #207 (comment)
This behavior is never documented.