Split input/inputFile options to their own file
#629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Dec 21, 2023
| @@ -69,7 +24,6 @@ const handleInputFileOption = (stdioStream, index, inputFile, input) => { | |||
|
|
|||
| const optionName = 'inputFile'; | |||
| validateInputOption(stdioStream.value, optionName); | |||
| validateRegularUrl(inputFile, optionName); | |||
There was a problem hiding this comment.
This is now handled by the validateFileStdio() method above, which has been slightly reworked.
ehmicky
commented
Dec 21, 2023
| @@ -29,7 +29,8 @@ export const isRegularUrl = stdioOption => isUrlInstance(stdioOption) && !hasFil | |||
|
|
|||
| const stringIsFilePath = stdioOption => stdioOption.startsWith('.') || isAbsolute(stdioOption); | |||
| const isFilePath = stdioOption => typeof stdioOption === 'string' && stringIsFilePath(stdioOption); | |||
| export const isUnknownStdioString = stdioOption => typeof stdioOption === 'string' && !stringIsFilePath(stdioOption) && !KNOWN_STDIO_STRINGS.has(stdioOption); | |||
|
|
|||
| export const isUnknownStdioString = (type, stdioOption) => type === 'native' && typeof stdioOption === 'string' && !KNOWN_STDIO_STRINGS.has(stdioOption); | |||
There was a problem hiding this comment.
native type is when the stdin/stdout/stderr value is passed directly to child_process.spawn(), as opposed to being handled by Execa. In that case, only few specific strings are allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small refactoring splitting the logic for the
inputandinputFileoptions to its own file.