Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #628

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Refactor tests #628

merged 1 commit into from
Dec 21, 2023

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Dec 21, 2023

This PR refactors the tests related to stdin/stdout/stderr/stdio/input/inputFile.
It does not change the logic in itself but instead:

  • Split into several smaller files
  • Remove duplicate code by using Ava test macros
  • Turn some sync I/O into async I/O instead, for better parallelism
  • Ensure every test is run on both execa() and execaSync()

@ehmicky ehmicky force-pushed the refactor-tests branch 3 times, most recently from 806b3dd to 6b6f547 Compare December 21, 2023 02:22
@sindresorhus
Copy link
Owner

Can you fix the conflict?

@ehmicky
Copy link
Collaborator Author

ehmicky commented Dec 21, 2023

Fixed the merged conflict, and made sure I kept the new tests added by the Buffer -> Uint8Array PR. 👍

@sindresorhus sindresorhus merged commit 30ecc81 into main Dec 21, 2023
14 checks passed
@sindresorhus sindresorhus deleted the refactor-tests branch December 21, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmicky @sindresorhus