Switch from Travis CI to GitHub Actions #504
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| - push | ||
| - pull_request | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Node.js ${{ matrix.node_version }} on ${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node_version: | ||
| - 13 | ||
| - 12 | ||
| - 10 | ||
| os: | ||
| - ubuntu-latest | ||
| - windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node_version }} | ||
| - run: npm install | ||
| - run: npm run test | ||
| - uses: coverallsapp/github-action@master | ||
| continue-on-error: true | ||
| with: | ||
| github-token: ${{ secrets.github_token }} | ||
| parallel: true | ||
|
|
||
| coverage: | ||
| needs: test | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: coverallsapp/github-action@master | ||
| continue-on-error: true | ||
| with: | ||
| github-token: ${{ secrets.github_token }} | ||
| parallel-finished: true | ||
|
|
||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12 | ||
| - run: npm install | ||
| - run: npm run lint | ||
|
|
||
| integration: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12 | ||
| - run: npm install | ||
| - run: npm run integration | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |
| "node": ">=10" | ||
| }, | ||
| "scripts": { | ||
| "test": "xo && nyc --reporter=lcov ava", | ||
fisker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "lint": "node ./test/lint/lint.js", | ||
| "integration": "node ./test/integration/test.js" | ||
| }, | ||
|
|
@@ -92,6 +92,9 @@ | |
| "eslint-plugin/require-meta-docs-url": "off" | ||
| } | ||
| } | ||
| ], | ||
| "rules": { | ||
| "import/order": "off" | ||
| } | ||
|
Comment on lines
+101
to
+103
There was a problem hiding this comment. This is really weird, see https://github.com/voxpelli/eslint-plugin-unicorn/runs/437762645?check_suite_focus=true There was a problem hiding this comment. |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cannot this just be part of the
testjob? I don't see what it does differently from the code in thetestjob either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job send a webhook to coveralls, need wait for all test job finished.
See #504 (comment) and #504 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why though? We only need coveralls to run in one of the test job, not all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed
parallel, and add a condition. only run on node.js 12 on linux