New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve lint script #426
Improve lint script #426
Conversation
Co-Authored-By: yakov116 <16872793+yakov116@users.noreply.github.com>
Ready. |
Co-Authored-By: yakov116 <16872793+yakov116@users.noreply.github.com>
- Open a pull request with a title in exactly the format `` Add `rule-name` rule ``, for example, `` Add `no-unused-properties` rule ``. | ||
- The pull request description should include the issue it fixes, for example, `Fixes #123`. | ||
- Run `$ npm run lint` to run the rules against codebase to ensure code in the repository are following your rule, _you can ignore this step until your PR is reviewed_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakov116 any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure maybe
to run the rules against the codebase. Ensuring that the rest of the codebase follows your rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not rest, new rule self may also not pass, should be all files
Skip
outputFixes
andreport
when there is no error.Add tips for how to fix.