Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-string-replace-all: Minor tweak to the message #1987

Merged
merged 1 commit into from Nov 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions rules/prefer-string-replace-all.js
Expand Up @@ -9,7 +9,7 @@ const MESSAGE_ID_USE_REPLACE_ALL = 'method';
const MESSAGE_ID_USE_STRING = 'pattern';
const messages = {
[MESSAGE_ID_USE_REPLACE_ALL]: 'Prefer `String#replaceAll()` over `String#replace()`.',
[MESSAGE_ID_USE_STRING]: 'This pattern can be replaced with a string {{replacement}}.',
[MESSAGE_ID_USE_STRING]: 'This pattern can be replaced with {{replacement}}.',
};

const selector = methodCallSelector({
Expand Down Expand Up @@ -97,7 +97,7 @@ const create = context => ({
messageId: MESSAGE_ID_USE_STRING,
data: {
// Show `This pattern can be replaced with a string literal.` for long strings
replacement: patternReplacement.length < 20 ? patternReplacement : 'literal',
replacement: patternReplacement.length < 20 ? patternReplacement : 'a string literal',
},
/** @param {import('eslint').Rule.RuleFixer} fixer */
fix: fixer => fixer.replaceText(pattern, patternReplacement),
Expand Down
2 changes: 1 addition & 1 deletion test/prefer-string-replace-all.mjs
Expand Up @@ -102,6 +102,6 @@ test.snapshot({

'foo.replaceAll(/a]/g, _)',
'foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)',
`foo.replaceAll(/a${' very'.repeat(30)} string/g, _)`,
`foo.replaceAll(/a${' very'.repeat(30)} long string/g, _)`,
],
});
12 changes: 6 additions & 6 deletions test/snapshots/prefer-string-replace-all.mjs.md
Expand Up @@ -579,7 +579,7 @@ Generated by [AVA](https://avajs.dev).

`␊
> 1 | foo.replaceAll(/a]/g, _)␊
| ^^^^^ This pattern can be replaced with a string 'a]'.␊
| ^^^^^ This pattern can be replaced with 'a]'.␊
`

## Invalid #36
Expand All @@ -595,21 +595,21 @@ Generated by [AVA](https://avajs.dev).

`␊
> 1 | foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)␊
| ^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string '\\r\\n😀'.␊
| ^^^^^^^^^^^^^^^^^ This pattern can be replaced with '\\r\\n😀'.␊
`

## Invalid #37
1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string/g, _)
1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string/g, _)

> Output

`␊
1 | foo.replaceAll('a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string', _)␊
1 | foo.replaceAll('a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string', _)␊
`

> Error 1/1

`␊
> 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string/g, _)␊
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string literal.␊
> 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string/g, _)␊
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string literal.␊
`
Binary file modified test/snapshots/prefer-string-replace-all.mjs.snap
Binary file not shown.