New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for rule jsdoc type comment #1612
Add test for rule jsdoc type comment #1612
Conversation
bdd6dde
to
2179743
Compare
I'm 👎 for this, this type info supposed to help rule author write the |
Maybe add this jsdoc to this function is useful. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/rules/utils/rule.js#L77 |
The jsdoc comment is only intended for the convenience of internal developers. What's the problem with testing to ensure each of our rules has it? |
Good idea, added (can be moved to separate PR if desired). |
This reverts commit 69b0960.
Extracted to separate PR: #1613 |
I agree we should enforce consistency here. |
Thanks. By the way, can we enable the GitHub setting "Automatically delete head branches", so we don't have to manually click "Delete branch" each time? |
Weird. It's already enabled. |
Follow-up to #1606
Ensures each rule has this jsdoc type comment. Otherwise, it would be easily forgotten in new rules.