New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm-run-all
to run test
and lint
scripts
#1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest also add a fix
version.
package.json
Outdated
"test": "xo && nyc ava && markdownlint '**/*.md'", | ||
"lint": "npm-run-all --continue-on-error --aggregate-output --parallel lint:*", | ||
"lint:js": "xo", | ||
"lint:md": "markdownlint '**/*.md'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe only double quote is supported on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Added |
Sorry, I didn't make myself clear. I prefer {
"lint": "",
"lint:a": "",
"lint:b": "",
"fix": "",
"fix:a": "",
"fix:b": ""
}
WDYT? Here is how I use. |
@fisker that's fine with me, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the action config file? https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/.github/workflows/main.yml#L28
Updated to have CI run However, this is why I personally prefer to have the test and lint scripts completely independent, so that CI can just run the |
Me too. But I guess sindresorhus prefers it in one. |
It looks like Windows CI doesn't like something about running
|
Try switch nyc to c8? |
I doubt |
I ran into similar thing, and fixed by using |
test
andlint
NPM scripts with popular tool npm-run-alltest
script would exit early if one type failed, so you wouldn't be able to see all the failures)&&
which might not have as good of cross-platform support according to the npm-run-all readme