Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-keyboard-event-key: Improve logic #1585

Merged
merged 1 commit into from Nov 9, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Nov 9, 2021

Found it during #1584, it didn't check node type, cause passing NaN to String.fromCharCode(), switch it to String.fromCodePoint(NaN) throws.

@sindresorhus sindresorhus merged commit a32d8f8 into sindresorhus:main Nov 9, 2021
@fisker fisker deleted the prefer-keyboard-event-key branch November 9, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants