Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for static blocks #1513

Merged
merged 3 commits into from Sep 8, 2021
Merged

Add test for static blocks #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27abd52
Add test for static blocks
fisker Sep 8, 2021
7b83149
Update comment
fisker Sep 8, 2021
1205dda
Add todo
fisker Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion rules/no-static-only-class.js
View file
Open in desktop
Expand Up @@ -40,7 +40,6 @@ function isStaticMember(node) {
} = node;

// Avoid matching unexpected node. For example: https://github.com/tc39/proposal-class-static-block
/* istanbul ignore next */
if (!isPropertyDefinition(node) && !isMethodDefinition(node)) {
return false;
}
Expand Down
19 changes: 18 additions & 1 deletion test/no-static-only-class.mjs
View file
Open in desktop
Expand Up @@ -16,6 +16,9 @@ test.snapshot({
'class A { constructor() {} }',
'class A { get a() {} }',
'class A { set a(value) {} }',
// TODO: enable this test when ESLint support `StaticBlock`
// Static block
// 'class A2 { static {}; }',
],
invalid: [
'class A { static a() {}; }',
Expand Down Expand Up @@ -91,6 +94,8 @@ test.typescript({
static a = 1;
}
`,
// Static block
'class A { static {}; }',
],
invalid: [
{
Expand Down Expand Up @@ -201,7 +206,19 @@ test.typescript({
});

test.babel({
valid: [],
testerOptions: {
parserOptions: {
babelOptions: {
parserOpts: {
plugins: ['classStaticBlock'],
},
},
},
},
valid: [
// Static block
'class A2 { static {}; }',
],
invalid: [
{
code: 'class A { static a() {} }',
Expand Down