Indicate which rules provide suggestions in readme rules table #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
readme-suggestions-table
branch
from
568016b
to
2068ea1
Compare
|
Actually, we can test this, some code here https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/utils/test.mjs should work. |
Added a test to ensure |
|
Yes, but add it to snapshot tester too, please. |
fisker
reviewed
May 21, 2021
fisker
reviewed
May 21, 2021
Co-authored-by: fisker Cheung <lionkay@gmail.com>
Co-authored-by: fisker Cheung <lionkay@gmail.com>
fisker
reviewed
May 21, 2021
test/utils/test.mjs
Outdated
| @@ -112,6 +117,7 @@ class Tester { | |||
| const tester = snapshotRuleTester(test, { | |||
| parserOptions: defaultParserOptions | |||
| }); | |||
| verifySuggestionPropertyConsistency(this.rule, tests.invalid); | |||
There was a problem hiding this comment.
This won't work because snapshot tester don't need set errors, should check here
fisker
reviewed
May 21, 2021
fisker
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1292.
This is another useful point of information about rules that we can include in our readme rules table.
Note that this property name/location will likely change slightly in ESLint 8 and become enforced so that it will be more reliable: eslint/eslint#14312