Add no-process-exit rule
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has anyone filed an issue w/ ESLint requesting the hashbang exception? Seems like a pretty reasonable improvement to core. 👍 for adopting this rule for XO (no matter where it lands). |
| if (callee.type === "MemberExpression" && | ||
| callee.object.name === "process" && | ||
| callee.property.name === "exit") { | ||
| context.report(node, "Don't use process.exit(); throw an error instead."); |
There was a problem hiding this comment.
Only use
process.exit()in CLI apps. Instead, throw an error.
jfmengels
force-pushed
the
no-process-exit
branch
from
3940d21
to
e789d3a
Compare
sindresorhus
pushed a commit
that referenced
this pull request
Apr 12, 2016
Adds `no-process-exit` rule. Same as the ESLint core rule, but with the exception of files that start with a hasbang `#!`. @sindresorhus asked me if I could implement this rule, and I thought it was fit to make a PR here.
sindresorhus
pushed a commit
that referenced
this pull request
Apr 12, 2016
Adds `no-process-exit` rule. Same as the ESLint core rule, but with the exception of files that start with a hasbang `#!`. @sindresorhus asked me if I could implement this rule, and I thought it was fit to make a PR here.
|
Woo! Glad to finally be able to use this rule :)
(Can you ever have enough Leo? I don't think so 😝) |
|
Glad you're happy with it :) (and I don't think it's possible to have enough of Leo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
no-process-exitrule. Same as the ESLint core rule, but with the exception of files that start with a hasbang#!.@sindresorhus asked me if I could implement this rule, and I thought it was fit to make a PR here.