-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce error message style #26
Comments
@jfmengels @jamestalmage @SamVerschueren Thoughts? |
Think I like |
@SamVerschueren It's a bad example though. What if you have 3 sentences and comma isn't valid to separate them. |
Not a big fan of this rule. I understand the frustration, but this will be hard to treat well, and will only work well when writing errors in English. Sounds to me like a rule that will be disabled more often than the others. |
Just wondering why this actually is the case? Why can't we just end all the messages with a dot? |
@SamVerschueren It's common convention to not end error messages in a dot, but it becomes weird when you have multiple sentences. |
@jfmengels Why will it be hard? And why do you think it will only work for English? It will work for any language that ends sentences with a |
avajs/ava#835 (comment)
I want to say:
This is a failure, you should use a blimp
Which of the following should it be:
Keep in mind that if we go for the last one, which looks the best, it becomes inconsistent with one sentence error messages, which usually don't end in a dot.
The text was updated successfully, but these errors were encountered: