fix: prefer-export-from do not convert type exports to value exports

sindresorhus · Feb 10, 2022 · 670afc3 · 670afc3
1 parent e8ab176
commit 670afc3
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/rules/prefer-export-from.js b/rules/prefer-export-from.js
@@ -109,9 +109,10 @@ function getFixFunction({
 	const sourceNode = importDeclaration.source;
 	const sourceValue = sourceNode.value;
 	const exportDeclaration = exportDeclarations.find(({source}) => source.value === sourceValue);
+	const isTypeExport = exported.node.parent.exportKind === "type"
 
 	/** @param {import('eslint').Rule.RuleFixer} fixer */
-	return function * (fixer) {
+	return function* (fixer) {
 		if (imported.name === NAMESPACE_SPECIFIER_NAME) {
 			yield fixer.insertTextAfter(
 				program,
@@ -122,20 +123,22 @@ function getFixFunction({
 				? exported.text
 				: `${imported.text} as ${exported.text}`;
 
+			const specifierWithKind = isTypeExport ? `type ${specifier}` : specifier
+
 			if (exportDeclaration) {
 				const lastSpecifier = exportDeclaration.specifiers[exportDeclaration.specifiers.length - 1];
 
 				// `export {} from 'foo';`
 				if (lastSpecifier) {
-					yield fixer.insertTextAfter(lastSpecifier, `, ${specifier}`);
+					yield fixer.insertTextAfter(lastSpecifier, `, ${specifierWithKind}`);
 				} else {
 					const openingBraceToken = sourceCode.getFirstToken(exportDeclaration, isOpeningBraceToken);
-					yield fixer.insertTextAfter(openingBraceToken, specifier);
+					yield fixer.insertTextAfter(openingBraceToken, specifierWithKind);
 				}
 			} else {
 				yield fixer.insertTextAfter(
 					program,
-					`\nexport {${specifier}} ${getSourceAndAssertionsText(importDeclaration, sourceCode)}`,
+					`\nexport {${specifierWithKind}} ${getSourceAndAssertionsText(importDeclaration, sourceCode)}`,
 				);
 			}
 		}