escape-case: Ignore String.raw (#2342)

sindresorhus · May 8, 2024 · 45bd444 · 45bd444
1 parent cc02a7f
commit 45bd444
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/rules/escape-case.js b/rules/escape-case.js
@@ -1,6 +1,7 @@
 'use strict';
 const {replaceTemplateElement} = require('./fix/index.js');
 const {isRegexLiteral, isStringLiteral} = require('./ast/index.js');
+const {isNodeMatches} = require('./utils/index.js');
 
 const MESSAGE_ID = 'escape-case';
 const messages = {
@@ -42,11 +43,22 @@ const create = context => {
 		}
 	});
 
-	context.on('TemplateElement', node => getProblem({
-		node,
-		original: node.value.raw,
-		fix: (fixer, fixed) => replaceTemplateElement(fixer, node, fixed),
-	}));
+	context.on('TemplateElement', node => {
+		const templateLiteral = node.parent;
+		if (
+			templateLiteral.parent.type === 'TaggedTemplateExpression'
+			&& templateLiteral.parent.quasi === templateLiteral
+			&& isNodeMatches(templateLiteral.parent.tag, ['String.raw'])
+		) {
+			return;
+		}
+
+		return getProblem({
+			node,
+			original: node.value.raw,
+			fix: (fixer, fixed) => replaceTemplateElement(fixer, node, fixed),
+		});
+	});
 };
 
 /** @type {import('eslint').Rule.RuleModule} */

diff --git a/test/escape-case.mjs b/test/escape-case.mjs
@@ -41,6 +41,7 @@ test({
 		'const foo = `foo\\\\\\\\xbar`;',
 		'const foo = `foo\\\\\\\\ubarbaz`;',
 		'const foo = `\\ca`;',
+		'const foo = String.raw`\\uAaAa`;',
 
 		// Literal regex
 		'const foo = /foo\\xA9/',
@@ -190,6 +191,18 @@ test({
 			errors,
 			output: 'const foo = `foo \\\\\\uD834`;',
 		},
+		// TODO: This is not safe, it will be broken if `tagged` uses `arguments[0].raw`
+		// #2341
+		{
+			code: 'const foo = tagged`\\uAaAa`;',
+			errors,
+			output: 'const foo = tagged`\\uAAAA`;',
+		},
+		{
+			code: 'const foo = `\\uAaAa```;',
+			errors,
+			output: 'const foo = `\\uAAAA```;',
+		},
 
 		// Mixed cases
 		{