Update eslint-plugin-eslint-plugin to v6 (#2336)

sindresorhus · May 7, 2024 · 204d31c · 204d31c
1 parent 45f23d5
commit 204d31c
Show file tree

Hide file tree

Showing 117 changed files with 140 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -79,7 +79,7 @@
 		"eslint": "^9.0.0",
 		"eslint-ava-rule-tester": "^5.0.1",
 		"eslint-doc-generator": "^1.7.0",
-		"eslint-plugin-eslint-plugin": "^5.2.1",
+		"eslint-plugin-eslint-plugin": "^6.1.0",
 		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
 		"eslint-remote-tester": "^3.0.1",
 		"eslint-remote-tester-repositories": "^1.0.1",

diff --git a/rules/better-regex.js b/rules/better-regex.js
@@ -136,6 +136,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Improve regexes by making them shorter, consistent, and safer.',
+			recommended: true,
 		},
 		fixable: 'code',
 		schema,

diff --git a/rules/catch-error-name.js b/rules/catch-error-name.js
@@ -128,6 +128,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce a specific parameter name in catch clauses.',
+			recommended: true,
 		},
 		fixable: 'code',
 		schema,

diff --git a/rules/consistent-destructuring.js b/rules/consistent-destructuring.js
@@ -157,6 +157,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Use destructured variables over properties.',
+			recommended: false,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/consistent-function-scoping.js b/rules/consistent-function-scoping.js
@@ -216,6 +216,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Move function definitions to the highest possible scope.',
+			recommended: true,
 		},
 		schema,
 		messages,

diff --git a/rules/custom-error-definition.js b/rules/custom-error-definition.js
@@ -208,6 +208,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce correct `Error` subclassing.',
+			recommended: false,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/empty-brace-spaces.js b/rules/empty-brace-spaces.js
@@ -65,6 +65,7 @@ module.exports = {
 		type: 'layout',
 		docs: {
 			description: 'Enforce no spaces between braces.',
+			recommended: true,
 		},
 		fixable: 'whitespace',
 		messages,

diff --git a/rules/error-message.js b/rules/error-message.js
@@ -98,6 +98,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce passing a `message` value when creating a built-in error.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/escape-case.js b/rules/escape-case.js
@@ -56,6 +56,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Require escape sequences to use uppercase values.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/expiring-todo-comments.js b/rules/expiring-todo-comments.js
@@ -581,6 +581,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Add expiration conditions to TODO comments.',
+			recommended: true,
 		},
 		schema,
 		messages,

diff --git a/rules/explicit-length-check.js b/rules/explicit-length-check.js
@@ -225,6 +225,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce explicitly comparing the `length` or `size` property of a value.',
+			recommended: true,
 		},
 		fixable: 'code',
 		schema,

diff --git a/rules/filename-case.js b/rules/filename-case.js
@@ -284,6 +284,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce a case style for filenames.',
+			recommended: true,
 		},
 		schema,
 		messages,

diff --git a/rules/import-style.js b/rules/import-style.js
@@ -363,6 +363,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce specific import styles per module.',
+			recommended: true,
 		},
 		schema,
 		messages,

diff --git a/rules/new-for-builtins.js b/rules/new-for-builtins.js
@@ -78,6 +78,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce the use of `new` for all builtins, except `String`, `Number`, `Boolean`, `Symbol` and `BigInt`.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-abusive-eslint-disable.js b/rules/no-abusive-eslint-disable.js
@@ -42,6 +42,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce specifying rules to disable in `eslint-disable` comments.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-anonymous-default-export.js b/rules/no-anonymous-default-export.js
@@ -205,6 +205,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow anonymous functions and classes as the default export.',
+			recommended: true,
 		},
 		hasSuggestions: true,
 		messages,

diff --git a/rules/no-array-callback-reference.js b/rules/no-array-callback-reference.js
@@ -278,6 +278,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Prevent passing a function reference directly to iterator methods.',
+			recommended: true,
 		},
 		hasSuggestions: true,
 		messages,

diff --git a/rules/no-array-for-each.js b/rules/no-array-for-each.js
@@ -475,6 +475,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Prefer `for…of` over the `forEach` method.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-array-method-this-argument.js b/rules/no-array-method-this-argument.js
@@ -216,6 +216,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow using the `this` argument in array methods.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-array-push-push.js b/rules/no-array-push-push.js
@@ -135,6 +135,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce combining multiple `Array#push()` into one call.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-array-reduce.js b/rules/no-array-reduce.js
@@ -119,6 +119,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow `Array#reduce()` and `Array#reduceRight()`.',
+			recommended: true,
 		},
 		schema,
 		messages,

diff --git a/rules/no-await-expression-member.js b/rules/no-await-expression-member.js
@@ -83,6 +83,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow member access from await expression.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-await-in-promise-methods.js b/rules/no-await-in-promise-methods.js
@@ -61,6 +61,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow using `await` in `Promise` method parameters.',
+			recommended: true,
 		},
 		hasSuggestions: true,
 		messages,

diff --git a/rules/no-console-spaces.js b/rules/no-console-spaces.js
@@ -79,6 +79,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Do not use leading/trailing space between `console.log` parameters.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-document-cookie.js b/rules/no-document-cookie.js
@@ -19,6 +19,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Do not use `document.cookie` directly.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-empty-file.js b/rules/no-empty-file.js
@@ -51,6 +51,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow empty files.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-for-loop.js b/rules/no-for-loop.js
@@ -419,6 +419,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Do not use a `for` loop that can be replaced with a `for-of` loop.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-hex-escape.js b/rules/no-hex-escape.js
@@ -39,6 +39,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce the use of Unicode escapes instead of hexadecimal escapes.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-instanceof-array.js b/rules/no-instanceof-array.js
@@ -58,6 +58,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Require `Array.isArray()` instead of `instanceof Array`.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-invalid-remove-event-listener.js b/rules/no-invalid-remove-event-listener.js
@@ -54,6 +54,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Prevent calling `EventTarget#removeEventListener()` with the result of an expression.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-keyword-prefix.js b/rules/no-keyword-prefix.js
@@ -192,6 +192,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow identifiers starting with `new` or `class`.',
+			recommended: false,
 		},
 		schema,
 		messages,

diff --git a/rules/no-lonely-if.js b/rules/no-lonely-if.js
@@ -144,6 +144,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow `if` statements as the only statement in `if` blocks without `else`.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-negated-condition.js b/rules/no-negated-condition.js
@@ -137,6 +137,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow negated conditions.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-nested-ternary.js b/rules/no-nested-ternary.js
@@ -51,6 +51,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow nested ternary expressions.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-new-array.js b/rules/no-new-array.js
@@ -96,6 +96,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow `new Array()`.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-new-buffer.js b/rules/no-new-buffer.js
@@ -90,6 +90,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce the use of `Buffer.from()` and `Buffer.alloc()` instead of the deprecated `new Buffer()`.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-null.js b/rules/no-null.js
@@ -144,6 +144,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow the use of the `null` literal.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-object-as-default-parameter.js b/rules/no-object-as-default-parameter.js
@@ -44,6 +44,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Disallow the use of objects as default parameters.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-process-exit.js b/rules/no-process-exit.js
@@ -98,6 +98,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow `process.exit()`.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-single-promise-in-promise-methods.js b/rules/no-single-promise-in-promise-methods.js
@@ -159,6 +159,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow passing single-element arrays to `Promise` methods.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-static-only-class.js b/rules/no-static-only-class.js
@@ -217,6 +217,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow classes that only have static members.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-thenable.js b/rules/no-thenable.js
@@ -192,6 +192,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Disallow `then` property.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-this-assignment.js b/rules/no-this-assignment.js
@@ -32,6 +32,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow assigning `this` to a variable.',
+			recommended: true,
 		},
 		messages,
 	},

diff --git a/rules/no-typeof-undefined.js b/rules/no-typeof-undefined.js
@@ -134,6 +134,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow comparing `undefined` using `typeof`.',
+			recommended: true,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

diff --git a/rules/no-unnecessary-await.js b/rules/no-unnecessary-await.js
@@ -99,6 +99,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow awaiting non-promise values.',
+			recommended: true,
 		},
 		fixable: 'code',
 

diff --git a/rules/no-unnecessary-polyfills.js b/rules/no-unnecessary-polyfills.js
@@ -169,6 +169,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce the use of built-in methods instead of unnecessary polyfills.',
+			recommended: true,
 		},
 		schema,
 		messages,

diff --git a/rules/no-unreadable-array-destructuring.js b/rules/no-unreadable-array-destructuring.js
@@ -76,6 +76,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow unreadable array destructuring.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

diff --git a/rules/no-unreadable-iife.js b/rules/no-unreadable-iife.js
@@ -38,6 +38,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow unreadable IIFEs.',
+			recommended: true,
 		},
 		hasSuggestions: false,
 		messages,

diff --git a/rules/no-unused-properties.js b/rules/no-unused-properties.js
@@ -232,6 +232,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Disallow unused object properties.',
+			recommended: false,
 		},
 		messages,
 	},