Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when modifying array length #89

Merged
merged 1 commit into from Jan 22, 2022
Merged

Fix crash when modifying array length #89

merged 1 commit into from Jan 22, 2022

Commits on Jan 22, 2022

  1. Fix crashing modifying array length 

    Also avoids unnecessary allocation and set.

Fixes cases like the following:
```javascript
let obj = { a: [1,2] };
dotProp.delete(obj, 'a.1');
dotProp.set(obj, 'a.length', 1);
```
Previously would throw `Uncaught RangeError: Invalid array length` when it tries to set `obj.a.length = {}`
    @Jimbly
    Jimbly committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    7ca5c6a View commit details
    Browse the repository at this point in the history