Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deepkeys for sparsed arrays #110

Merged
merged 1 commit into from Jul 18, 2023
Merged

fix deepkeys for sparsed arrays #110

merged 1 commit into from Jul 18, 2023

Conversation

AuthorProxy
Copy link
Contributor

@AuthorProxy AuthorProxy commented Jul 4, 2023 •
edited

fix #108 and #109

This was referenced Jul 4, 2023
Closed
Closed
@AuthorProxy AuthorProxy force-pushed the fix_deepkeys_for_sparsed_arrays branch from d638cf8 to c7df662 Compare July 4, 2023 18:38
@sindresorhus
Copy link
Owner

You also need to update the readme about sparse keys: https://github.com/sindresorhus/dot-prop#deepkeysobject

@AuthorProxy AuthorProxy force-pushed the fix_deepkeys_for_sparsed_arrays branch from c7df662 to f0f21ca Compare July 18, 2023 12:27
@AuthorProxy
Copy link
Contributor Author

@sindresorhus updated

@sindresorhus sindresorhus merged commit e314e80 into sindresorhus:main Jul 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepKeys doesn't work with sparsed arrays: ".for is not iterable"
2 participants
@AuthorProxy @sindresorhus