Fix crash when modifying array length (#89)

sindresorhus · Jan 22, 2022 · d363922 · d363922
1 parent 0289e19
commit d363922
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -219,12 +219,10 @@ export function setProperty(object, path, value) {
 
 		assertNotStringIndex(object, key);
 
-		if (!isObject(object[key])) {
-			object[key] = typeof pathArray[index + 1] === 'number' ? [] : {};
-		}
-
 		if (index === pathArray.length - 1) {
 			object[key] = value;
+		} else if (!isObject(object[key])) {
+			object[key] = typeof pathArray[index + 1] === 'number' ? [] : {};
 		}
 
 		object = object[key];

diff --git a/test.js b/test.js
@@ -245,6 +245,11 @@ test('setProperty', t => {
 			bar: true,
 		}],
 	});
+
+	const fixture7 = {foo: ['bar', 'baz']};
+	setProperty(fixture7, 'foo.length', 1);
+	t.is(fixture7.foo.length, 1);
+	t.deepEqual(fixture7, {foo: ['bar']});
 });
 
 test('deleteProperty', t => {