Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes when wrapping text containing colorized content #52

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -124,7 +124,7 @@ module.exports = (text, options) => {
const createdLines = wrapAnsi(line, max, {hard: true});
const alignedLines = ansiAlign(createdLines, {align: options.align});
const alignedLinesArray = alignedLines.split('\n');
const longestLength = Math.max(...alignedLinesArray.map(s => s.length));
const longestLength = Math.max(...alignedLinesArray.map(s => stringWidth(s)));

for (const alignedLine of alignedLinesArray) {
let paddedLine;
Expand Down
28 changes: 28 additions & 0 deletions test.js
Expand Up @@ -315,6 +315,34 @@ test('align option `left`', t => {
`);
});

test('align option (left) does not throw when colorized content > columns', t => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is not crashing without my fix but I've included it for completeness

console.log('process.stdout.columns', process.stdout.columns);
const longContent = chalk.green('ab').repeat(process.stdout.columns);
t.notThrows(() => {
boxen(longContent, {
align: 'left'
});
});
});

test('align option (center) does not throw when colorized content > columns', t => {
const longContent = chalk.green('ab').repeat(process.stdout.columns);
t.notThrows(() => {
boxen(longContent, {
align: 'center'
});
});
});

test('align option (right) does not throw when colorized content > columns', t => {
const longContent = chalk.green('ab').repeat(process.stdout.columns);
t.notThrows(() => {
boxen(longContent, {
align: 'right'
});
});
});
Comment on lines +328 to +344
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that those are not the best tests as they don't quite test the final result but I won't have time to dig into writing better ones.


test('dimBorder option', t => {
const dimTopBorder = chalk.dim('┌───┐');
const dimSide = chalk.dim('│');
Expand Down