Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
const enum
in index.d.ts with a regular enum. This lets boxen (or any packages that depend on it) be used in projects whose tsconfig has the settingisolatedModules:true
.Hi! I was going to make an issue, but figured I'd make a PR with a suggested fix too.
Problem: I want to use update-notifier in a typescript project. My project has
isolatedModules: true
(because we're compiling with babel-preset-typescript, and trying to match variations across the two). Trying to typecheck this project fails withwhich is expected, of course. But I can't seem to figure out a workaround for this that doesn't rely on using
skipLibCheck: true
, which would suck. Would it be possible for you to replace the const enum here with a regular enum? I made this change locally and it appeared to work fine, but I'm not clear what the broader implications are.Please and thank you!