Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boxen dependency to 5.0.0 for update-notifier #50315

Closed
wants to merge 1 commit into from

Conversation

LukeSheard
Copy link
Contributor

@LukeSheard LukeSheard commented Dec 29, 2020

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Don't use TypeScript const enum sindresorhus/boxen#50
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 29, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 29, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 29, 2020

@LukeSheard Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have passed
  • ❌ Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 50315,
  "author": "LukeSheard",
  "headCommitAbbrOid": "b809688",
  "headCommitOid": "b809688fe3a47b0e35b28096ba426fc2d5f24bff",
  "lastPushDate": "2020-12-29T10:38:27.000Z",
  "lastActivityDate": "2020-12-29T16:24:59.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "update-notifier",
      "kind": "edit",
      "files": [
        {
          "path": "types/update-notifier/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "vvakame",
        "nchen63",
        "bitjson",
        "grinich",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b809688fe3a47b0e35b28096ba426fc2d5f24bff/checks?check_suite_id=1738237087"
}

@typescript-bot
Copy link
Contributor

🔔 @vvakame @nchen63 @bitjson @grinich @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Dec 29, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Dec 29, 2020
@typescript-bot
Copy link
Contributor

@LukeSheard The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #50315 diff
Batch compilation
Memory usage (MiB) 75.6 76.6 +1.4%
Type count 12161 13049 +7%
Assignability cache size 3611 3774 +5%
Language service
Samples taken 67 67 0%
Identifiers in tests 67 67 0%
getCompletionsAtPosition
    Mean duration (ms) 449.5 462.6 +2.9%
    Mean CV 11.5% 11.2%
    Worst duration (ms) 566.6 582.6 +2.8%
    Worst identifier update notifier
getQuickInfoAtPosition
    Mean duration (ms) 447.5 458.6 +2.5%
    Mean CV 10.9% 10.8%
    Worst duration (ms) 556.6 544.3 -2.2%
    Worst identifier update update

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Dec 29, 2020
@peterblazejewicz
Copy link
Member

@LukeSheard update-notifier itself is locked to the 4.2 version:
https://github.com/yeoman/update-notifier/blob/master/package.json#L37

@LukeSheard
Copy link
Contributor Author

@peterblazejewicz Oh yeah - in my head I raised yeoman/update-notifier#202 so then I needed to get this updated as well. I'll close this for now and re-open it when the PR is merged.

@LukeSheard LukeSheard closed this Dec 29, 2020
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants