New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update boxen
dependency to 5.0.0 for update-notifier
#50315
Conversation
@LukeSheard Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 50315,
"author": "LukeSheard",
"headCommitAbbrOid": "b809688",
"headCommitOid": "b809688fe3a47b0e35b28096ba426fc2d5f24bff",
"lastPushDate": "2020-12-29T10:38:27.000Z",
"lastActivityDate": "2020-12-29T16:24:59.000Z",
"maintainerBlessed": false,
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "update-notifier",
"kind": "edit",
"files": [
{
"path": "types/update-notifier/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"vvakame",
"nchen63",
"bitjson",
"grinich",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b809688fe3a47b0e35b28096ba426fc2d5f24bff/checks?check_suite_id=1738237087"
} |
🔔 @vvakame @nchen63 @bitjson @grinich @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
@LukeSheard The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@LukeSheard |
@peterblazejewicz Oh yeah - in my head I raised yeoman/update-notifier#202 so then I needed to get this updated as well. I'll close this for now and re-open it when the PR is merged. |
Please fill in this template.
If changing an existing definition:
const enum
sindresorhus/boxen#50