Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support … as punctuation in list-item rule #98

Merged
merged 3 commits into from
Jul 12, 2020
Merged

Support … as punctuation in list-item rule #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
871ef5c
[rules/list-item.js] support for … as punctuation
arthurlutz Apr 7, 2020
f9248c0
[rules/list-item.js] documentation update following review
arthurlutz Jun 3, 2020
19a69ba
Update 0.md
arthurlutz Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions rules/list-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ function validateListItemDescription(description, file) {
return false;
}

// Ensure description ends with '.', '!', '?' or an acceptable special-case
// Ensure description ends with '.', '!', '?', '…' or an acceptable special-case
if (suffix.type === 'text' && !validateListItemSuffix(descriptionText, suffixText)) {
file.message('List item description must end with proper punctuation', suffix);
return false;
Expand Down Expand Up @@ -276,8 +276,8 @@ function validateListItemPrefix(descriptionText, prefixText) {
}

function validateListItemSuffix(descriptionText, suffixText) {
if (/[.!?]\s*$/.test(suffixText)) {
// Description ends with '.', '!', or '?'
if (/[.!?…]\s*$/.test(suffixText)) {
// Description ends with '.', '!', '?' or '…'
return true;
}

Expand Down
1 change: 1 addition & 0 deletions test/fixtures/list-item/0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ All list-items in this document should be linted as **valid**.
- [foo](https://foo.com) - Valid description.
- [foo](https://foo.com) - A valid description.
- [foo](https://foo.com) - A valid description...
- [foo](https://foo.com) - A valid description…
- [foo](https://foo.com) - A valid description!
- [foo](https://foo.com) - A valid description! ⭐
- [foo](https://foo.com) - A valid description!!!
Expand Down