Skip to content

Commit

Permalink
Support as punctuation in list-item rule (#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
arthurlutz committed Jul 12, 2020
1 parent 978805e commit eac2755
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions rules/list-item.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ function validateListItemDescription(description, file) {
return false;
}

// Ensure description ends with '.', '!', '?' or an acceptable special-case
// Ensure description ends with '.', '!', '?', '…' or an acceptable special-case
if (suffix.type === 'text' && !validateListItemSuffix(descriptionText, suffixText)) {
file.message('List item description must end with proper punctuation', suffix);
return false;
Expand Down Expand Up @@ -276,8 +276,8 @@ function validateListItemPrefix(descriptionText, prefixText) {
}

function validateListItemSuffix(descriptionText, suffixText) {
if (/[.!?]\s*$/.test(suffixText)) {
// Description ends with '.', '!', or '?'
if (/[.!?]\s*$/.test(suffixText)) {
// Description ends with '.', '!', '?' or ''
return true;
}

Expand Down
1 change: 1 addition & 0 deletions test/fixtures/list-item/0.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ All list-items in this document should be linted as **valid**.
- [foo](https://foo.com) - Valid description.
- [foo](https://foo.com) - A valid description.
- [foo](https://foo.com) - A valid description...
- [foo](https://foo.com) - A valid description…
- [foo](https://foo.com) - A valid description!
- [foo](https://foo.com) - A valid description! ⭐
- [foo](https://foo.com) - A valid description!!!
Expand Down

0 comments on commit eac2755

Please sign in to comment.