CI: test rack-session head, test only latest JRuby
#1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the intention with sinatra#1974 but I must have forgot about it.
JRuby 9.3 still relevant, was a release not long ago: https://github.com/jruby/jruby/releases/tag/9.3.13.0
On the workflow summary page this key is displayed, currently is says
Matrix: rack-protection
Matrix: test
This would be nicer
Matrix: rack-protection
Matrix: sinatra
JRuby jobs takes ~2m40s but CRuby jobs take <1min. The CRuby 2.6 job should hopefully catch anything not working in JRuby 9.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits.
Prep for #1945.