Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative URL for the 404 image #1943

Merged
merged 1 commit into from Sep 1, 2023
Merged

Use relative URL for the 404 image #1943

merged 1 commit into from Sep 1, 2023

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Aug 31, 2023

We already do for the 500 image, see 238eede

Close #1939

@dentarg
Use relative URL for the 404 image
5631635 
We already do for the 500 image, see 238eede
Avoids "Host Header" XSS.

Close sinatra#1939
@dentarg dentarg mentioned this pull request Aug 31, 2023
Closed
@dentarg dentarg requested a review from a team August 31, 2023 22:00
jkowens
jkowens approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@jkowens jkowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dentarg dentarg merged commit 9c08af4 into sinatra:main Sep 1, 2023
14 checks passed
@dentarg dentarg deleted the 404-uri-img-fix branch September 1, 2023 06:32
@dentarg dentarg mentioned this pull request Nov 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowens jkowens jkowens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XSS via Host Header Injection
2 participants
@dentarg @jkowens