Actually remove thin from server selection #1830
Closed
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sinatra#1624 `thin` is still left in this block, which keeps it the most preferred server in regular Ruby. Let's remove it for real this time.
|
Oops, I misread that issue. I still have the question about whether thin should be the most preferred server though, even with falcon/puma installed. |
|
@felixonmars yeah I think we have the list backwards. |
|
It was decided to keep thin support since it appears it is once again getting some support. I do think it should be the first server in the server list, giving puma and falcon priority, but I wouldn't introduce that change until v4. |
|
@jkowens I see. Thanks for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1624
thinis still left in this block, which keeps it the most preferred server in regular Ruby. Let's remove it for real this time.