Revert to using stderr.puts for start up message #1818
Conversation
There was a problem hiding this comment.
Looks good! However I think is worth commenting that in this case the Rubocop change was wrong only because Sinatra has its own warn method defined https://github.com/sinatra/sinatra/blob/master/lib/sinatra/base.rb#L1775-L1777 that adds the from... line
We could reconsider the utility of such warn method and if we find it useful we could rename it so we don't mess with Ruby methods.
|
@epergo Good eye! What if that supporting method got a new name, such as |
|
@olleolleolle I think that is a good idea. It looks like that method is only used one place right now, the |
jkowens
force-pushed
the
fix-boot-message
branch
2 times, most recently
from
ffc2680
to
8773621
Compare
jkowens
force-pushed
the
fix-boot-message
branch
from
8773621
to
21db005
Compare
That looks great 🚀
Right, we could have dropped it for Sinatra V3 but I think we can remove it in a minor release, no need to wait for a major for this. |
Fixes #1813.