Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Refer to rack/rack default branch as 'main' #1815

Merged
merged 3 commits into from Sep 26, 2022

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Sep 26, 2022

This PR changes the configured branch name for a GitHub Actions matrix element that runs our test suite with the latest development code of Rack.

Rack has changed the name of the default branch, to main. This PR now reflects the current default branch of that repository.

Issue manifests in CI as:

Revision master does not exist in the repository
https://github.com/rack/rack.git. Maybe you misspelled it?

After this change, we get this, which is more of what we want from a CI job like this (which is exploring the next major version):

Fetching https://github.com/rack/rack.git
Fetching https://github.com/rack/rack-test.git
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Bundler could not find compatible versions for gem "rack":
In Gemfile:
rack-protection was resolved to 3.0.0, which depends on
rack

sinatra was resolved to 3.0.0, which depends on
  rack (~> 2.2, >= 2.2.4)

Could not find gem 'rack (~> 2.2, >= 2.2.4)', which is required by gem
'rack-protection', in https://github.com/rack/rack.git (at main@ab9cd74).

The source contains the following gems matching 'rack':

  • rack-3.0.0

Mildly related to #1797

This reflects the current default branch of that repository.

Issue manifests in CI as:

Revision master does not exist in the repository
https://github.com/rack/rack.git. Maybe you misspelled it?
@olleolleolle olleolleolle changed the title CI: Rename rack default branch to 'main' CI: Rename rack default branch to 'main' to match current name Sep 26, 2022
@olleolleolle
Copy link
Member Author

Ah, I see, there are also Gemfile changes I need to deal with!

@olleolleolle olleolleolle marked this pull request as draft September 26, 2022 08:48
@olleolleolle olleolleolle marked this pull request as ready for review September 26, 2022 08:54
@olleolleolle
Copy link
Member Author

Even if things are utterly broken on our side, they're broken for the right reasons, and they break on code not being matched, not due to "we could not download the git repo contents".

@olleolleolle olleolleolle changed the title CI: Rename rack default branch to 'main' to match current name CI: Refer to rack/rack default branch as 'main' Sep 26, 2022
Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@jkowens jkowens closed this Sep 26, 2022
@jkowens jkowens reopened this Sep 26, 2022
@jkowens jkowens merged commit e521b60 into sinatra:master Sep 26, 2022
@olleolleolle olleolleolle deleted the patch-5 branch September 26, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants