Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Stylus #1697

Merged
merged 1 commit into from Oct 3, 2021
Merged

Conversation

epergo
Copy link
Member

@epergo epergo commented May 17, 2021

Contributes to #1690

stylus hasn't been maintained for a long time. Support for stylus will be dropped in the next major version upgrade.

@zzak
Copy link
Member

zzak commented May 17, 2021

@epergo I'm thinking we should start a branch called unstable or something that we can start making 3.x PRs against. 🤔

@epergo
Copy link
Member Author

epergo commented May 17, 2021

@epergo I'm thinking we should start a branch called unstable or something that we can start making 3.x PRs against. 🤔

It makes sense, if not we are going to have a lot PRs piled up until we decide to start merging them. Another alternative could be having branches per stable releases and treat master like edge (like I think Rails does), but I guess that is more cumbersome for maintainers so whatever works for you 😄

@zzak
Copy link
Member

zzak commented May 17, 2021

@epergo The reason I want to avoid merging many unreleased changes to main is that releases in the past have been slow and I know some people are just using github "sinatra/sinatra" in their Gemfiles.

@epergo
Copy link
Member Author

epergo commented May 18, 2021

Sounds good to me! As soon as we have the unstable branch I'll update the PR

@epergo epergo changed the base branch from master to unstable May 20, 2021 07:14
@epergo epergo changed the base branch from unstable to master May 20, 2021 07:15
@epergo epergo changed the base branch from master to unstable May 21, 2021 09:59
@epergo
Copy link
Member Author

epergo commented Sep 11, 2021

@zzak I changed the target branch to unstable do you think we can merge this?

@jkowens jkowens merged commit 556149d into sinatra:unstable Oct 3, 2021
jkowens pushed a commit that referenced this pull request Oct 4, 2021
jkowens pushed a commit that referenced this pull request Oct 4, 2021
@epergo epergo deleted the ep/1690-drop-stylus branch October 4, 2021 07:35
jkowens pushed a commit that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants