Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce RDoc generation time by not including every README #1671

Merged
merged 3 commits into from Jan 7, 2021
Merged

Reduce RDoc generation time by not including every README #1671

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
677d89c
Remove unused variable
Dec 28, 2020
9fbb02d
Remove RDoc `--inline-source` option as is the default behaviour
Dec 28, 2020
2041c46
Only add the english README when generating RDoc
Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions sinatra.gemspec
View file
Open in desktop
Expand Up @@ -20,8 +20,8 @@ Gem::Specification.new 'sinatra', version do |s|
"sinatra.gemspec",
"VERSION"]
s.test_files = s.files.select { |p| p =~ /^test\/.*_test.rb/ }
s.extra_rdoc_files = s.files.select { |p| p =~ /^README/ } << 'LICENSE'
s.rdoc_options = %w[--line-numbers --inline-source --title Sinatra --main README.rdoc --encoding=UTF-8]
s.extra_rdoc_files = %w[README.md LICENSE]
s.rdoc_options = %w[--line-numbers --title Sinatra --main README.rdoc --encoding=UTF-8]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed --inline-source because is the default behaviour


if s.respond_to?(:metadata)
s.metadata = {
Expand All @@ -33,11 +33,6 @@ Gem::Specification.new 'sinatra', version do |s|
'documentation_uri' => 'https://www.rubydoc.info/gems/sinatra'
}
else
msg = "RubyGems 2.0 or newer is required to protect against public "\
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable wasn't used

"gem pushes. You can update your rubygems version by running:\n\n"\
"gem install rubygems-update\n"\
"update_rubygems\n"\
"gem update --system"
raise <<-EOF
RubyGems 2.0 or newer is required to protect against public gem pushes. You can update your rubygems version by running:
gem install rubygems-update
Expand Down