Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of inherited Sinatra::Base classes keyword arguments #1670

Merged
merged 10 commits into from Jan 7, 2021
Merged

Fix usage of inherited Sinatra::Base classes keyword arguments #1670

merged 10 commits into from Jan 7, 2021
+21 −3

Commits on Dec 17, 2020

  1. Fix usage of inherited Sinatra::Base classes keyword arguments 

    Using keyword arguments on inherited classes from Sinatra::Base breaks
with ArgumentError: wrong number of arguments (given X, expected 0).

This commit fixes the usage of it on Ruby3 by allowing the method to
accept both positional and keyword arguments.
    @duduribeiro
    duduribeiro committed Dec 17, 2020
    Copy the full SHA
    64347b0 View commit details
    Browse the repository at this point in the history

  2. Include tests

    @duduribeiro
    duduribeiro committed Dec 17, 2020
    Copy the full SHA
    06e049c View commit details
    Browse the repository at this point in the history

  3. Import rvm Key on travis pipeline

    @duduribeiro
    duduribeiro committed Dec 17, 2020
    Copy the full SHA
    561ec54 View commit details
    Browse the repository at this point in the history

  4. Trying to use ruby-head instead of ruby-3.0.0-preview1 to avoid errors

    @duduribeiro
    duduribeiro committed Dec 17, 2020
    Copy the full SHA
    be56991 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Returning ruby-3.0.0 to test it on xenial linux

    @duduribeiro
    duduribeiro committed Dec 18, 2020
    Copy the full SHA
    3c80f4f View commit details
    Browse the repository at this point in the history

  2. Upgrade to Xenial

    @duduribeiro
    duduribeiro committed Dec 18, 2020
    Copy the full SHA
    a5ed7fb View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Merge branch 'master' into fix_positional_arguments_in_ruby_3

    @duduribeiro
    duduribeiro committed Dec 29, 2020
    Copy the full SHA
    605d7bf View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @duduribeiro
    duduribeiro committed Dec 29, 2020
    Copy the full SHA
    b979ca6 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Change initialize method to accept kwargs

    @duduribeiro
    duduribeiro committed Dec 30, 2020
    Copy the full SHA
    2760659 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_positional_arguments_in_ruby_3

    @duduribeiro
    duduribeiro committed Dec 30, 2020
    Copy the full SHA
    77e6872 View commit details
    Browse the repository at this point in the history