Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use prepend instead of include for helpers. Fixes #1213" #1662

Merged
merged 5 commits into from Nov 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sinatra/base.rb
Expand Up @@ -1441,7 +1441,7 @@ def unlink(path, opts = {}, &bk) route 'UNLINK', path, opts, &bk end
# in `extensions` available to the handlers and templates
def helpers(*extensions, &block)
class_eval(&block) if block_given?
prepend(*extensions) if extensions.any?
include(*extensions) if extensions.any?
end

# Register an extension. Alternatively take a block from which an
Expand Down
2 changes: 1 addition & 1 deletion sinatra-contrib/lib/sinatra/namespace.rb
Expand Up @@ -238,7 +238,7 @@ def self.prefixed(*names)

def helpers(*extensions, &block)
class_eval(&block) if block_given?
prepend(*extensions) if extensions.any?
include(*extensions) if extensions.any?
end

def register(*extensions, &block)
Expand Down
52 changes: 52 additions & 0 deletions test/helpers_test.rb
Expand Up @@ -1949,6 +1949,10 @@ def foo
end

it 'prepends modules so previously-defined methods can be overridden consistently' do
skip <<-EOS
This test will be helpful after switching #helpers's code from Module#include to Module#prepend
See more details: https://github.com/sinatra/sinatra/pull/1214
EOS
mock_app do
helpers do
def one; nil end
Expand All @@ -1969,5 +1973,53 @@ def two; '2' end
get '/two'
assert_equal '2', body
end

module HelpersOverloadingBaseHelper
def my_test
'BaseHelper#test'
end
end

class HelpersOverloadingIncludeAndOverride < Sinatra::Base
helpers HelpersOverloadingBaseHelper

get '/' do
my_test
end

helpers do
def my_test
'InlineHelper#test'
end
end
end

it 'uses overloaded inline helper' do
mock_app(HelpersOverloadingIncludeAndOverride)
get '/'
assert ok?
assert_equal 'InlineHelper#test', body
end

module HelperWithIncluded
def self.included(base)
base.extend(ClassMethods)
end

module ClassMethods
def nickname(name)
# do something.
end
end
end

class ServerApp < Sinatra::Base
helpers HelperWithIncluded
# `nickname` method should be available.
end

it 'calls included method of helpers' do
assert ServerApp.respond_to?(:nickname)
end
end
end