Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "none" a keyword in content security policy #1594

Closed
wants to merge 1 commit into from

Conversation

mfinelli
Copy link
Contributor

As-is the default 'none' gets interpreted as a hostname not a keyword.
To make it a keyword it needs to be wrapped in single quotes.

As-is the default 'none' gets interpreted as a hostname not a keyword.
To make it a keyword it needs to be wrapped in single quotes.
@olleolleolle
Copy link
Member

You can read about the 'none' single-quotes on the MDN page about it:

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/default-src

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks solid, and the tests are updated in a consistent way.

LGTM!

@jkowens
Copy link
Member

jkowens commented Mar 13, 2020

Resolved by #1490.

@jkowens jkowens closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants