Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated code for Tilt 1.x versions #1532

Merged
merged 4 commits into from Jun 23, 2019
Merged

Remove outdated code for Tilt 1.x versions #1532

merged 4 commits into from Jun 23, 2019

Commits on Apr 28, 2019

  1. Remove outdated code for Tilt 1.x versions support 

    I found out that Sinatra codebase still contains code for handling
both versions of Tilt (1.x and 2.x), however starting from Sinatra 2.0
the minimally required version of Tilt is 2.0 as well.

This commit removes old code and cleans up a bit how tests for
different markdown engines are generated.
    @304
    304 committed Apr 28, 2019
    Copy the full SHA
    1d19193 View commit details
    Browse the repository at this point in the history

  2. Add commonmarker gem 

    It resolves following warning in tests:
```
cannot load such file -- commonmarker: skipping markdown tests with Tilt::CommonMarkerTemplate
```
    @304
    304 committed Apr 28, 2019
    Copy the full SHA
    c0dd32e View commit details
    Browse the repository at this point in the history

  3. Fix warning: assigned but unused variable

    @304
    304 committed Apr 28, 2019
    Copy the full SHA
    9f6c262 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. Deprecate tilt 1.x support for sinatra-contrib

    @304
    304 committed May 1, 2019
    Copy the full SHA
    c4ec883 View commit details
    Browse the repository at this point in the history