Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rack-protection] Drop Ruby 1.8 compat code #1528

Merged
merged 2 commits into from May 4, 2019
Merged

[rack-protection] Drop Ruby 1.8 compat code #1528

merged 2 commits into from May 4, 2019
+11 −21

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Apr 12, 2019 •
edited

This PR cleans up Ruby 1.8 compatibility code.

Same kind of thing as #1527

@olleolleolle olleolleolle changed the title Drop Ruby 1.8 compat code [rack-protection] Drop Ruby 1.8 compat code Apr 12, 2019
@jkowens
Copy link
Member

jkowens commented Apr 19, 2019

LGTM

namusyaka
namusyaka approved these changes May 4, 2019
View reviewed changes
Copy link
Member

@namusyaka namusyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@namusyaka namusyaka merged commit 494c1f2 into sinatra:master May 4, 2019
@olleolleolle olleolleolle deleted the patch-4 branch May 4, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namusyaka namusyaka namusyaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olleolleolle @jkowens @namusyaka