Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndifferentHash monkeypatch warning improvements #1477

Merged
merged 1 commit into from Nov 4, 2018

Conversation

mwpastore
Copy link
Member

  • Print warning on Rubies that require monkeypatching only
  • Print warning to stderr instead of stdout
  • Load ActiveSupport during internal testing only
  • Add SINATRA_ACTIVESUPPORT_WARNING opt-out environment variable

First spike at addressing #1476

@selzoc
Copy link

selzoc commented Oct 15, 2018

This looks awesome! Any idea when it may be merged?

* Print warning on Rubies that require monkeypatching only
* Print warning to stderr instead of stdout
* Load ActiveSupport during internal testing only
* Add SINATRA_ACTIVESUPPORT_WARNING opt-out environment variable
@namusyaka namusyaka added this to the v2.0.5 milestone Nov 4, 2018
@namusyaka namusyaka self-requested a review November 4, 2018 10:48
Copy link
Member

@namusyaka namusyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namusyaka namusyaka merged commit 68908ff into sinatra:master Nov 4, 2018
@DannyBen
Copy link

DannyBen commented Dec 8, 2018

When is this planned to find its way into a release?

@DannyBen
Copy link

DannyBen commented Jan 4, 2019

Thank you! 2.0.5 with its sinatra-contrib both look great!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 6, 2019
## 2.0.5 / 2018-12-22

* Avoid FrozenError when params contains frozen value [#1506](sinatra/sinatra#1506) by Kunpei Sakai

* Add support for Erubi [#1494](sinatra/sinatra#1494) by @tkmru

* `IndifferentHash` monkeypatch warning improvements [#1477](sinatra/sinatra#1477) by Mike Pastore

* Improve development support and documentation and source code by Anusree Prakash, Jordan Owens, @ceclinux and @krororo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants