sinatra-namespace: Allow for set :<engine>

[mkaito]

This allows to set render engine options local to a namespace

Fixes #1254

[zzak]

This is neat, thank you for the patch!

Let's consider it for after a 2.0 release is made 🙇‍♂️

[namusyaka]

Could you add a spec for testing this behavior?

[mkaito]

I don't even know where to begin with that. I'll try, though.

[namusyaka]

Allowed keys should be defined as a constant.

[olleolleolle]

@mkaito Example constant names: ALLOWED_RENDER_ENGINE_KEYS, RENDER_ENGINE_NAMES, et cetera.

[olleolleolle]

Here's a spec which explains the behaviour:

diff --git a/sinatra-contrib/spec/namespace_spec.rb b/sinatra-contrib/spec/namespace_spec.rb
index 15381560..be06370a 100644
--- a/sinatra-contrib/spec/namespace_spec.rb
+++ b/sinatra-contrib/spec/namespace_spec.rb
@@ -818,5 +818,15 @@ describe Sinatra::Namespace do
       get '/foo-bar'
       expect(last_response.body).to eq('[:foo_bar]')
     end
+
+    it 'forbids unknown engine settings' do
+      expect {
+        mock_app do
+          namespace '/foo' do
+            set :unknownsetting
+          end
+        end
+      }.to raise_error(ArgumentError, 'may not set unknownsetting')
+    end
   end
 end

[namusyaka]

@mkaito Hey, could you still address on this? If not, another patch is welcome.

[mkaito]

I... Completely forgot about this. Sorry. Yes, I'll look at it again as soon as I have a little time. El 6 de marzo de 2018 13:13:14 GMT+00:00, namusyaka <notifications@github.com> escribió:

…

@mkaito Hey, could you still address on this? If not, another patch is welcome. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #1255 (comment)

-- Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.

[namusyaka]

Don't worry. Just listening to that reply is enough.
Thanks.

[olleolleolle]

I think this looks great and the test explains what happens when used wrong.

Let's get this merged!

[olleolleolle]

@jkowens Hooray! 🎉