Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass on JRuby 9.4 #1886

Closed
dentarg opened this issue Feb 22, 2023 · 3 comments
Closed

Make tests pass on JRuby 9.4 #1886

dentarg opened this issue Feb 22, 2023 · 3 comments

Comments

@dentarg
Copy link
Member

dentarg commented Feb 22, 2023

We allow them to fail currently:

# Due to https://github.com/jruby/jruby/issues/7647
- { ruby: jruby-9.4, rack: '~> 2', puma: stable, tilt: '~> 2.0.0', allow-failure: true }

I thought it was a problem with JRuby, so I reported jruby/jruby#7647, but as seen in that issue, it is not, the problem is with rack: rack/rack#1610 (missing delegate require) It is fixed in Rack 3, but will likely never be fixed for Rack 2.

(This wasn't a problem with JRuby 9.3 because the missing delegate require is only a problem in Ruby versions >2.6: jruby/jruby#7647 (comment))

It is still a mystery to me why only the JRuby tests fail though 🤔 I would really appreciate someone explaining that

@dentarg
Copy link
Member Author

dentarg commented Jul 11, 2023

Rack backport PR: rack/rack#2092

@dentarg
Copy link
Member Author

dentarg commented Jul 31, 2023

Rack backport PR: rack/rack#2092

It is part of rack 2.2.8 released today: https://rubygems.org/gems/rack/versions/2.2.8

@dentarg dentarg self-assigned this Jul 31, 2023
@dentarg
Copy link
Member Author

dentarg commented Sep 16, 2023

Yeah, rack 2.2.8 resolved this, JRuby 9.4 tests pass here: https://github.com/dentarg/sinatra/actions/runs/5753078429/job/15595497187#step:7:17

And they failed here with rack 2.2.7: https://github.com/dentarg/sinatra/actions/runs/5576942970/job/15101401844#step:7:43

@dentarg dentarg closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant