Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.0 regression in JRuby handling of inherited Sinatra::Base keyword args #1749

Closed
yaauie opened this issue Feb 16, 2022 · 2 comments · Fixed by #1750
Closed

2.2.0 regression in JRuby handling of inherited Sinatra::Base keyword args #1749

yaauie opened this issue Feb 16, 2022 · 2 comments · Fixed by #1750

Comments

@yaauie
Copy link

yaauie commented Feb 16, 2022 •
edited

#1670 provides a fix to move forward with Ruby 3.0's Keyword arguments, but it comes at the expense of breaking Sinatra when run under JRuby.

ArgumentError: wrong number of arguments (given 3, expected 1..2)

With backtrace

/usr/share/logstash/logstash-core/lib/logstash/api/modules/base.rb:43:in `initialize'
/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/sinatra-2.2.0/lib/sinatra/base.rb:1537:in `new'
/usr/share/logstash/logstash-core/lib/logstash/api/rack_app.rb:113:in `block in app'
...

I have filed a separate bug upstream with jruby (jruby/jruby#7102), but am hoping we can find a path foward here in Sinatra while we wait for JRuby to come up with a fix.
dentarg added a commit to dentarg/sinatra that referenced this issue Feb 16, 2022
@dentarg
Use ruby2_keywords for delegation
e814c6f 
Follows the "The Only Correct Way" from https://eregon.me/blog/2021/02/13/correct-delegation-in-ruby-2-27-3.html

Related to sinatra#1670
Fixes sinatra#1749
@dentarg dentarg mentioned this issue Feb 16, 2022
Merged
@dentarg
Copy link
Member

dentarg commented Feb 16, 2022

@yaauie can you try #1750?

@yaauie yaauie mentioned this issue Feb 17, 2022
Open
@yaauie
Copy link
Author

yaauie commented Feb 17, 2022

I answered over on #1750 that it resolves the situation for Logstash.

@kares kares mentioned this issue Feb 21, 2022
Merged
@yaauie yaauie mentioned this issue Apr 13, 2022
Closed
jkowens pushed a commit that referenced this issue Apr 14, 2022
@dentarg @jkowens
Use ruby2_keywords for delegation
88e2148 
Follows the "The Only Correct Way" from https://eregon.me/blog/2021/02/13/correct-delegation-in-ruby-2-27-3.html

Related to #1670
Fixes #1749
jkowens pushed a commit that referenced this issue Apr 14, 2022
@dentarg @jkowens
Use ruby2_keywords for delegation
3dd160b 
Follows the "The Only Correct Way" from https://eregon.me/blog/2021/02/13/correct-delegation-in-ruby-2-27-3.html

Related to #1670
Fixes #1749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ruby2_keywords for delegation dentarg/sinatra
2 participants
@dentarg @yaauie