Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to release 2.2.1 to fix JRuby #1773

Closed
yaauie opened this issue Apr 13, 2022 · 4 comments
Closed

Request to release 2.2.1 to fix JRuby #1773

yaauie opened this issue Apr 13, 2022 · 4 comments
Assignees

Comments

@yaauie
Copy link

yaauie commented Apr 13, 2022

Sinatra 2.2.0 (released on 2022-02-15) is broken on JRuby (#1749).

A much-appreciated quick follow up fix was merged (#1750) less than a week later, along with adding JRuby to the CI matrix (#1755), but ~50 days have passed and the latest available release on JRuby is still broken.

Is it possible to get a 2.2.1 release cut including these changes?

@jkowens
Copy link
Member

jkowens commented Apr 13, 2022

@namusyaka we might have to just cut a 3.0 release unless you think we should branch off the 2.2.0 tag and create a 2.2.1 release?

@yaauie
Copy link
Author

yaauie commented Apr 14, 2022

It would be disappointing to have the last release in the 2.x series be permanently broken on JRuby, especially when fixes were available so quickly after its release. While Logstash currently pins to 2.1.0 to avoid the issue, we have a lot of old releases in the wild whose plugin manager automatically pulls in this broken Sinatra when our users update other plugins.

@jkowens
Copy link
Member

jkowens commented Apr 14, 2022

@namusyaka I ported the patches to a 2-2-stable branch. Hopefully it's all set for you to cut a 2.2.1 release.

@jkowens
Copy link
Member

jkowens commented Jul 15, 2022

2.2.1 has been released 🎉

@jkowens jkowens closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants