Skip to content

Commit

Permalink
Sinatra::Contrib dependency updates. Fixes #1207 (#1411)
Browse files Browse the repository at this point in the history
* Remove backports
* Work around Object#try and String#underscore
  • Loading branch information
namusyaka committed Mar 13, 2020
1 parent 330d9b4 commit 8ddf4f9
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 22 deletions.
32 changes: 16 additions & 16 deletions sinatra-contrib/lib/sinatra/contrib.rb
Expand Up @@ -7,32 +7,32 @@ module Contrib
# or breaks if external dependencies are missing. Will extend
# Sinatra::Application by default.
module Common
register :ConfigFile
register :MultiRoute
register :Namespace
register :RespondWith
register :ConfigFile, 'sinatra/config_file'
register :MultiRoute, 'sinatra/multi_route'
register :Namespace, 'sinatra/namespace'
register :RespondWith, 'sinatra/respond_with'

helpers :Capture
helpers :ContentFor
helpers :Cookies
helpers :EngineTracking
helpers :JSON
helpers :LinkHeader
helpers :Streaming
helpers :RequiredParams
helpers :Capture, 'sinatra/capture'
helpers :ContentFor, 'sinatra/content_for'
helpers :Cookies, 'sinatra/cookies'
helpers :EngineTracking, 'sinatra/engine_tracking'
helpers :JSON, 'sinatra/json'
helpers :LinkHeader, 'sinatra/link_header'
helpers :Streaming, 'sinatra/streaming'
helpers :RequiredParams, 'sinatra/required_params'
end

##
# Other extensions you don't want to be loaded unless needed.
module Custom
# register :Compass
register :Reloader
# register :Compass, 'sinatra/compass'
register :Reloader, 'sinatra/reloader'
end

##
# Stuff that aren't Sinatra extensions, technically.
autoload :Extension
autoload :TestHelpers
autoload :Extension, 'sinatra/extension'
autoload :TestHelpers, 'sinatra/test_helpers'
end

register Sinatra::Contrib::Common
Expand Down
8 changes: 3 additions & 5 deletions sinatra-contrib/lib/sinatra/contrib/setup.rb
@@ -1,6 +1,5 @@
require 'sinatra/base'
require 'sinatra/contrib/version'
require 'backports/rails/string' # for String#underscore

module Sinatra
module Contrib
Expand All @@ -9,16 +8,15 @@ def extensions
@extensions ||= {:helpers => [], :register => []}
end

def register(name, path = nil)
def register(name, path)
autoload name, path, :register
end

def helpers(name, path = nil)
def helpers(name, path)
autoload name, path, :helpers
end

def autoload(name, path = nil, method = nil)
path ||= "sinatra/#{name.to_s.underscore}"
def autoload(name, path, method = nil)
extensions[method] << name if method
Sinatra.autoload(name, path)
end
Expand Down
1 change: 0 additions & 1 deletion sinatra-contrib/sinatra-contrib.gemspec
Expand Up @@ -38,7 +38,6 @@ EOF

s.add_dependency "sinatra", version
s.add_dependency "mustermann", "~> 1.0"
s.add_dependency "backports", ">= 2.8.2"
s.add_dependency "tilt", "~> 2.0"
s.add_dependency "rack-protection", version
s.add_dependency "multi_json"
Expand Down

0 comments on commit 8ddf4f9

Please sign in to comment.