Fix issue with Ruby 3 keyword arguments #126
Conversation
|
Going to merge, since this seems good for now. |
| @@ -73,6 +73,7 @@ def self.translate(*types, &block) | |||
| Class.new(const_get(:NodeTranslator)) do | |||
| register(*types) | |||
| define_method(:translate, &block) | |||
| ruby2_keywords :translate | |||
There was a problem hiding this comment.
@jkowens I think you want the if too, otherwise Ruby 2.6 and lower won't be supported? http://eregon.me/blog/2021/02/13/correct-delegation-in-ruby-2-27-3.html, sinatra/sinatra#1750
There was a problem hiding this comment.
http://eregon.me/blog/2019/11/10/the-delegation-challenge-of-ruby27.html says ruby2_keywords is a no-op in Ruby 2.6 but I suspect it doesn't exist before that (I haven't checked though), so that's probably why CI doesn't complain
(Also haven't checked what min Ruby version is required by Sinatra/mustermann)
There was a problem hiding this comment.
@dentarg ah shoot, I'm actually seeing warning messages now that I look. Maybe this isn't the right solution...this code is hard for me to follow 😅
There was a problem hiding this comment.
Oh we don't need the if because we depend on the ruby2_keywords gem
mustermann/mustermann/mustermann.gemspec
Line 17 in 21a0b3e
|
FYI #130 is the proper fix. |
@dentarg this seems to fix the issue with a failing spec in Ruby 3, is it the right way to fix this?